Fix flaky cache test #6373
Open
Fix flaky cache test #6373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
reviewed
Nov 14, 2025
Co-authored-by: josh11b <[email protected]>
josh11b
reviewed
Nov 17, 2025
Comment on lines
-612
to
-613
| auto stale_runtimes_0_inode = | ||
| stale_runtimes[0].base_dir().Stat()->unix_inode(); |
Contributor
There was a problem hiding this comment.
Removing this will no longer compile.
Comment on lines
+645
to
+648
| EXPECT_FALSE(stale_runtimes_0.base_dir().Stat()->unix_inode() | ||
| == stale_runtimes_0_inode && | ||
| stale_runtimes_0.base_dir().Stat()->mtime() | ||
| == stale_runtimes_0_mtime); |
Contributor
There was a problem hiding this comment.
[diff] reported by reviewdog 🐶
Suggested change
| EXPECT_FALSE(stale_runtimes_0.base_dir().Stat()->unix_inode() | |
| == stale_runtimes_0_inode && | |
| stale_runtimes_0.base_dir().Stat()->mtime() | |
| == stale_runtimes_0_mtime); | |
| EXPECT_FALSE(stale_runtimes_0.base_dir().Stat()->unix_inode() == | |
| stale_runtimes_0_inode && | |
| stale_runtimes_0.base_dir().Stat()->mtime() == | |
| stale_runtimes_0_mtime); |
Contributor
|
I don't think this is quite the right way to fix the test. Rather than relying on timestamps, we can force the I've sent #6387 which does this, and also makes some other improvements to make it easier to debug if this keeps happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test in runtimes_cache_test.cpp that gives a false failure when the filesystem reuses the inode of a stale cache entry.
Closes #6168